Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving Cake.Git dependency with a separate NuGet library #383

Closed
pleonex opened this issue Oct 8, 2023 · 2 comments
Closed

Consider moving Cake.Git dependency with a separate NuGet library #383

pleonex opened this issue Oct 8, 2023 · 2 comments

Comments

@pleonex
Copy link

pleonex commented Oct 8, 2023

As far as I understand, this recipe can either use Cake.Git or the Git CLI to get some information. Personally I prefer Git CLI as I always have issues with libgit2sharp native libraries in Linux distros (having incompatible glibc versions).
If I choose to use the Git CLI, I would still have the dependency with Cake.Git which I shouldn't need. This causes some issues:

  • Libgit2sharp along all of its native libraries for all OSes are downloaded and copied to the output folder
  • Due to Cake.Git issue 137, adding a reference to Cake.Issues.Recipe will cause a warning in my project. Furthermore, I won't be able to use dotnet-script to write my build scripts.

The suggestion is to move the code that uses Cake.Git into a separate NuGet, just like Cake.Issues.DocFx, so if you choose the CLI version you don't have that dependency.

@pascalberger
Copy link
Member

Moving code into a separate NuGet package won't make a difference, since Libgit2sharp is already wrapped in a separate NuGet package (Cake.Git). Cake.Issues.DocFx is also not an example which you can compare, since DocFx log file parsing is not supported out of the box in the recipe. Other issue provider (e.g. Cake.Issues.MsBuild) are also downloaded everytime.
What would be required is dynamic loading of the addins which are required based on configuration (#17).

@pascalberger
Copy link
Member

pascalberger commented Mar 8, 2024

Starting with version 4.0 Cake.Frosting.Issues.Recipe has now a dependency to Cake.Frosting.Git which no longer will result in a warning when using with Cake Frosting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants