Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method toNative() has gone missing #432

Closed
shadowhand opened this issue Oct 2, 2023 · 5 comments · Fixed by #433
Closed

Method toNative() has gone missing #432

shadowhand opened this issue Oct 2, 2023 · 5 comments · Fixed by #433
Milestone

Comments

@shadowhand
Copy link

shadowhand commented Oct 2, 2023

#417 (review)

According to Semantic Versioning, methods and attributes MAY NOT be removed except in major releases. The toNative() method was present in versions 3.0.0 and 3.0.1, but removed in 3.0.2. This breaks expectations and trust in versioning.

@dereuromark
Copy link
Member

Yes that removal was invalid, but got corrected
#427
Are u sure it is gone in your downloaded code and the actual release?

@dereuromark
Copy link
Member

Ah, chronos class itself it is still missing

@shadowhand
Copy link
Author

According to PR #417 it was removed in Chronos, ChronosDate, and ChronosTime. According to PR #427 it was only restored to ChronosDate and ChronosTime.

And yes, I have confirmed that the released package 3.0.2 does NOT have Chronos::toNative() method.

@markstory markstory added this to the 3.x milestone Oct 2, 2023
markstory added a commit that referenced this issue Oct 2, 2023
This was accidently removed in the shuffle of #417 and #427

Fixes #432
@dereuromark
Copy link
Member

Pr open, will be released asap!

@shadowhand
Copy link
Author

Thanks for the quick resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants