Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency Selector modal design changes #1634

Closed
machikoyasuda opened this issue Aug 10, 2023 · 2 comments · Fixed by #1646
Closed

Agency Selector modal design changes #1634

machikoyasuda opened this issue Aug 10, 2023 · 2 comments · Fixed by #1646
Assignees
Labels
front-end HTML/CSS/JavaScript and Django templates

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Aug 10, 2023

Make changes to agency selector modal code as necessary to fit new design as spec'd out here #1444
Ticket should be done after #1631 #1588

Needs

  • Need to get the correctly sized logos from Figma (or Design)

Acceptance criteria

  • All logos are hard-coded to the new Desktop and Mobile dimensions
  • SBMTD logo should fit in the new space
  • Ensure spacing around the titles, X, etc. are also all correct
  • If it makes sense, combine modal template with modal-info template so we can just have 1 template. (But if the spacing is really off and different between the two... as it stands now in Figma, then perhaps, it makes sense to have 2 templates).

Design specs

Mobile

Image

Image

Desktop

Image

Image

Image

Image

@machikoyasuda machikoyasuda added the front-end HTML/CSS/JavaScript and Django templates label Aug 10, 2023
@machikoyasuda machikoyasuda added this to the SBMTD milestone Aug 10, 2023
@machikoyasuda
Copy link
Member Author

@angela-tran made this new ticket to reflect dev work needs from #1223 #1444

@machikoyasuda
Copy link
Member Author

On the last bullet point, I started comparing and contrasting the 2 modal designs (Agency Selector and Info Modals). I don't think it's advisable to combine them into one includes template. Both Desktop and Mobile versions have different header heights, padding/margin and spacing - so it would be tough to get all the spacing classses right.

@machikoyasuda machikoyasuda self-assigned this Aug 10, 2023
@machikoyasuda machikoyasuda moved this from Todo to In Progress in Digital Services Aug 10, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Digital Services Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant