-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle JavaScript / Cookie alert banners to match that of Skip Nav banner #1652
Comments
@srhhnry What color should the warning text be? That same blue as the link? |
Since we see the need for a new component here, I propose we put this issue through a proper design phase. That will allow us to articulate the problem it solves, explore a couple different solutions to make sure the design teams believes this approach will work, and mockup each state of the component. Since the errors we're covering are edge cases, we can begin design in the Sept sprint (or possibly implement if the design is complete ahead of the sprint.) |
Agreed @indexing. The design should cover what it looks like when:
|
@machikoyasuda The "skip nav" is primarily a desktop enhancement, but I assume we need to have mobile states for the bottom two? |
@indexing yes |
@thekaveman @machikoyasuda @angela-tran
|
|
A real user should never see this one -- I propose we ignore / don't worry about styling. |
The message bar uses this code from the CA State Web Template v5: https://legacy.template.webstandards.ca.gov/sample/alert-banner.html So although a user should never see this, we have the code that creates these in the application: |
Note: Skip Nav that is currently on https://test-benefits.calitp.org/ does not have a sufficient color contrast. When designing links, keep in mind that links can be either their original color, or, it can be the Here's the full error message from an accessibility test tool. They recommend changing the blue from
|
Leaving a note that this design is ready but on pause until further notice @indexing |
Since #1645 merged, we have a new Skip Nav banner style:
This ticket is to update the JavaScript and Cookie banners to have the same style (background color, text color, link colors, spacing, etc.)
E.g. the JavaScript banner currently looks like:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: