Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tag fetching in CI #401

Closed
2 tasks
thekaveman opened this issue Jan 8, 2024 · 0 comments · Fixed by #402
Closed
2 tasks

Simplify tag fetching in CI #401

thekaveman opened this issue Jan 8, 2024 · 0 comments · Fixed by #402
Assignees
Labels
actions Related to GitHub Actions workflows bug Something isn't working chore Chores and tasks for code cleanup, dev experience, etc.

Comments

@thekaveman
Copy link
Member

thekaveman commented Jan 8, 2024

@angela-tran this was a great find and fix!

I think it can be done a bit simpler directly from the actions/checkout@v4 step:

- uses: actions/checkout@v4
  with:
    # Number of commits to fetch. 0 indicates all history for all branches and tags.
    # Default: 1
    fetch-depth: 0 
    
    # Whether to fetch tags, even if fetch-depth > 0.
    # Default: false
    fetch-tags: true

Maybe the fetch-depth doesn't matter as much when we force fetch-tags, which would be even simpler!

We also noticed this as a potential problem for the auto release notes generation happening in the release workflow

Acceptance criteria

Originally posted by @thekaveman in #392 (comment)

@thekaveman thekaveman added the actions Related to GitHub Actions workflows label Jan 8, 2024
@thekaveman thekaveman added the chore Chores and tasks for code cleanup, dev experience, etc. label Jan 8, 2024
@thekaveman thekaveman added the bug Something isn't working label Jan 9, 2024
@thekaveman thekaveman changed the title Possibly simplify tag fetching for Docker build in CI Simplify tag fetching in CI Jan 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Digital Services Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows bug Something isn't working chore Chores and tasks for code cleanup, dev experience, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants