Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slush: Refactor - Plan out how to convert SCSS into CSS #569

Closed
machikoyasuda opened this issue Jul 29, 2024 · 7 comments
Closed

Slush: Refactor - Plan out how to convert SCSS into CSS #569

machikoyasuda opened this issue Jul 29, 2024 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@machikoyasuda
Copy link
Member

Research shaping ticket

@machikoyasuda machikoyasuda self-assigned this Jul 29, 2024
@machikoyasuda machikoyasuda added the documentation Improvements or additions to documentation label Jul 30, 2024
@machikoyasuda
Copy link
Member Author

The easiest way to start:

  • Start converting one file at a time from SCSS to CSS written in a SCSS file: Convert mixin to regular media query, convert nesting into regular CSS.
  • Prioritize the files that are of repeated styles (header, footer, component blocks)
  • Don't actually change the SCSS pipeline.
  • Convert SCSS variables to CSS variables

@machikoyasuda
Copy link
Member Author

Component-specific changes:

  • Button override file - Re-create button using Bootstrap CSS Variable overrides for Primary and Outline Primary

@machikoyasuda
Copy link
Member Author

Combine some files, to reduce overload:

  • Combine Base, Button, Layout, Main Content, Footnotes, Pills
  • Convert Header and Page Header
  • Combine/Convert Table, Filterable Table
  • Newsletter
  • TOC & Content
  • Utilities
  • Home, Imaged Section
  • Contactless pages: Combine Go, How to Go

@machikoyasuda
Copy link
Member Author

Prioritize: Being able to have the same base Bootstrap CSS Variable overrides for links, buttons and share styles for Header, Footer.

Prioritize using and creating utilities, so that we have fewer CSS files/styles

@machikoyasuda
Copy link
Member Author

Moving forward, only write CSS and try to only write utilities.

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Aug 8, 2024

Proof of concept PR: #574

  • Figured out how to best convert the media query mixins to CSS

I think it would take 2 days, including testing, to do a meaningful chunk of the conversion, scoped to all the non-page file SCSS. If we use the above PR as a starting point, probably just 1 extra day - including testing.

@machikoyasuda
Copy link
Member Author

Marking this as closed b/c the research, scoping and plan has been created in the above comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

1 participant