Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track system config stuff #22

Open
udeved opened this issue Aug 18, 2016 · 6 comments
Open

track system config stuff #22

udeved opened this issue Aug 18, 2016 · 6 comments

Comments

@udeved
Copy link
Contributor

udeved commented Aug 18, 2016

keep track on stuff to do after moving config to livecd for iso

@udeved
Copy link
Contributor Author

udeved commented Aug 19, 2016

Would be very nice if upstream implemented writing displaymanagers to globalstorage.

Right before last line's return in displaymanager main.py:

libcalamares.globalstorage.insert("displayManagers", displaymanagers)

I made it so that postcfg makes use of displayManagers, so manjaro doesn't have to deploy its own displaymanager module @philmmanjaro @teo .

@philmmanjaro
Copy link
Member

Fork the calamares repo, create a new branch if needed and modify the modules as you may think fit. Then request a normal pull so we can review your work upstream.

@udeved
Copy link
Contributor Author

udeved commented Aug 19, 2016

I have pushed both in calamares-manjaro.
However, just this one line should go upstream and we drop our displaymanager. ;)

@philmmanjaro
Copy link
Member

You have to create a pull request in calamares repo and not add a custom module to calamares-manjaro repo. I can review your work and create that pull request myself if needed. This however later, maybe tomorrow.

@udeved
Copy link
Contributor Author

udeved commented Aug 19, 2016

I can do PR for this one line upstream change, no problem.
Once its merged, we drop the custom displaymanager module.

@udeved
Copy link
Contributor Author

udeved commented Aug 19, 2016

calamares/calamares#251

@philmmanjaro

I took out keyboard.conf writing in postcfg, I think its useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants