Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for scrolling inside elements #23

Closed
straku opened this issue Dec 8, 2015 · 5 comments
Closed

Support for scrolling inside elements #23

straku opened this issue Dec 8, 2015 · 5 comments

Comments

@straku
Copy link

straku commented Dec 8, 2015

Did you think about adding support for scrolling inside elements? I think that it could be used like this:

Jump.jump('.selector', {
  duration:500,
  container: '.widget'
})

I know that it would require rather significant changes in the way that scrolling is handled, but maybe it is a nice idea for future improvements.

@callmecavs
Copy link
Owner

will definitely consider it for a future enhancement - not sure the juice is worth the squeeze though, because I think the predominant use case for smooth scrolling is in relation to the page. added the enhancement label, will put some thought into it

@straku
Copy link
Author

straku commented Dec 8, 2015

Don't think about it in terms of simple websites (like landing pages) but rather SPA. In my experience it is quite common to have fixed navbar and menu and all of application elements in a single panel. With scrolling on window object it is impossible to use Jump.js in this situation. There are other libraries that support this behavior (example) but I really, really, really like the simplicity of Jump.js and its ES6 support, so please consider this enhancement. Fingers crossed!

@callmecavs
Copy link
Owner

fair point about SPAs, definitely worth supporting them if possible. I'll likely implement it, but it might be a week or 2 down the road

@mrenty
Copy link

mrenty commented Dec 10, 2015

I added this enhancement with fallback for the window, and prepared PR #24 for this.

@callmecavs
Copy link
Owner

please see #31, and leave your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants