Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: feedback when event could not be triggered due to disabled state, etc #1718

Open
mdjastrzebski opened this issue Dec 18, 2024 · 2 comments

Comments

@mdjastrzebski
Copy link
Member

Describe the Feature

Provide user feedback when user could not be triggered due to disabled state, missing event handler, etc

Possible Implementations

Option on configure not to break existing Fire Event / User Event APIs. This option would probably have to be opt-in, as some users are relying on event not being triggered in disabled states.

Related Issues

CC: @pierrezimmermannbam @MattAgn @AugustinLF wdyt?

@MattAgn
Copy link
Collaborator

MattAgn commented Dec 19, 2024

Totally agree! Would be great for devX and to debug tests more easily.
I think the best would be to log a warning by default and opt out of the option if needed, otherwise i fear not many people will hear about it and remember to turn it on

@pierrezimmermannbam
Copy link
Collaborator

This could be very interesting indeed! I'm not too sure about missing handler because you would get a warning by targeting eg a Text within a Button and relying on event bubbling but it could be very useful for disabled states. I would personnally use it if it was for disabled states only because I don't usually trigger events on disabled elements but rather use toBeDisabled matcher but I do agree that at least it should be possible to opt out. What I'm not too sure is wether it should be activated by default or not but I believe it would be a good default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants