Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildcache doesn't track dup, dup2, dup3 #4

Open
lstewart opened this issue Mar 8, 2016 · 0 comments
Open

buildcache doesn't track dup, dup2, dup3 #4

lstewart opened this issue Mar 8, 2016 · 0 comments

Comments

@lstewart
Copy link

lstewart commented Mar 8, 2016

discovered by noticing that make test1 fails on systems which have an /etc/motd

test1 uses sort(1) as an exemplar build command. At least one version of sort does a
dup2(3,1) to set its output file descriptor to 1

buildcache tracks the write to this output file, but the file decriptor is unknown, so buildcache skips it (silently).

Either a write to an unknown fd should be an error, or (better) buildcache should track dup, dup2, dup3

Generally this seems straightforward, we add suitable regular expressions to buildcache to decode the dup system calls, and copy the open file information to the new fd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant