New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table definition can contain '/' - wrong pattern #26

Open

Enyby opened this issue Dec 6, 2017 · 1 comment

Enyby commented Dec 6, 2017

php-mysql-diff/src/RegExpPattern.php

Line 38 in a12f964

$pattern .= '\((?<tableDefinition>[^\/]+?)\)';

Because you replace comments with base64. Read RFC 2045. '/' is 63 symbol in Base64.

drez commented May 7, 2020

I have comments with '/', I changed the line to:
$pattern .= '((?.+?))';
Works fine so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment