Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Email Send() calls are error-prone #39

Open
samritchie opened this issue Jun 20, 2016 · 0 comments
Open

Transaction Email Send() calls are error-prone #39

samritchie opened this issue Jun 20, 2016 · 0 comments

Comments

@samritchie
Copy link

When calling methods like https://github.com/campaignmonitor/createsend-dotnet/blob/master/createsend-dotnet/Transactional/ClassicEmail.cs#L8 the combination of optional named params, variadic to params, and implicit conversion on EmailAddress makes it very easy to get the call wrong (it will compile, but pass the wrong parameters and throw a misleading error message).

I suggest either removing the params and providing overloads for single & multiple 'to' addresses, and/or making the ClassicEmail class public and allowing client code to pass through an instance to Send().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant