From 7ae9e7ab5353db05d3d9b30437b8820a7850a990 Mon Sep 17 00:00:00 2001
From: Camille Moinier <cmoinier@wrk208.wrk.prs.camptocamp.com>
Date: Fri, 3 May 2024 13:44:51 +0200
Subject: [PATCH 1/3] feat: add new links in footer

---
 .../footer/mel-datahub-footer.component.html  | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/libs/mel/src/lib/footer/mel-datahub-footer.component.html b/libs/mel/src/lib/footer/mel-datahub-footer.component.html
index 2e0db373..71911780 100644
--- a/libs/mel/src/lib/footer/mel-datahub-footer.component.html
+++ b/libs/mel/src/lib/footer/mel-datahub-footer.component.html
@@ -82,7 +82,7 @@
         </li>
         <li class="flex">
           <a
-            href="https://www.youtube.com/channel/UC8u2Ore30NYveCLHzj82DRA"
+            href="https://youtube.com/@metropoledelille"
             target="_blank"
             class="hover:outline-offset-4 hover:border-b-2 hover:border-red-600"
           >
@@ -129,16 +129,20 @@
       </ul>
     </div>
     <div class="flex flex-row items-center flex-wrap">
-      <img
-        class="h-20 mr-8"
-        src="{{ iconsUrl }}finance_ue.png"
-        [alt]="'mel.common.footer.logo.financeUE' | translate"
-      />
-      <img
-        class="h-24"
-        src="{{ iconsUrl }}france_relance.png"
-        [alt]="'mel.common.footer.logo.franceRelance' | translate"
-      />
+      <a href="https://next-generation-eu.europa.eu/index_fr">
+        <img
+          class="h-20 mr-8"
+          src="{{ iconsUrl }}finance_ue.png"
+          [alt]="'mel.common.footer.logo.financeUE' | translate"
+        />
+      </a>
+      <a href="https://www.economie.gouv.fr/plan-de-relance">
+        <img
+          class="h-24"
+          src="{{ iconsUrl }}france_relance.png"
+          [alt]="'mel.common.footer.logo.franceRelance' | translate"
+        />
+      </a>
     </div>
     <div class="flex flex-row items-center">
       <span class="text-xs leading-3 mr-10" translate=""

From ef427ee3bf5b696aaabf136954f0c4a8cfdd5cf7 Mon Sep 17 00:00:00 2001
From: Camille Moinier <cmoinier@wrk208.wrk.prs.camptocamp.com>
Date: Fri, 3 May 2024 16:06:01 +0200
Subject: [PATCH 2/3] fix: fix e2e test

---
 apps/home-e2e/src/e2e/home.cy.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/home-e2e/src/e2e/home.cy.ts b/apps/home-e2e/src/e2e/home.cy.ts
index 19b92d43..ab75da6d 100644
--- a/apps/home-e2e/src/e2e/home.cy.ts
+++ b/apps/home-e2e/src/e2e/home.cy.ts
@@ -93,7 +93,7 @@ describe('home', () => {
         .first()
         .children('div')
         .eq(1)
-        .children('img')
+        .children('a')
         .should('have.length', 2)
     })
     it('should have a button to the newsletter subscription', () => {

From 81d75ef0810ca068fbacc2a13d71d1645d53a5c5 Mon Sep 17 00:00:00 2001
From: Tobias Kohr <tobias.kohr@camptocamp.com>
Date: Tue, 7 May 2024 09:39:29 +0200
Subject: [PATCH 3/3] feat(footer): open icon links in new tab

---
 apps/home-e2e/src/e2e/home.cy.ts                       | 10 +++++++++-
 .../src/lib/footer/mel-datahub-footer.component.html   |  4 ++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/apps/home-e2e/src/e2e/home.cy.ts b/apps/home-e2e/src/e2e/home.cy.ts
index ab75da6d..a4c15538 100644
--- a/apps/home-e2e/src/e2e/home.cy.ts
+++ b/apps/home-e2e/src/e2e/home.cy.ts
@@ -85,7 +85,7 @@ describe('home', () => {
       cy.get('@url').should('include', 'twitter')
       cy.get('@url').should('include', 'MetropoleLille')
     })
-    it('should display the partners icons', () => {
+    it('should display the partners icons as links', () => {
       cy.get('@footer')
         .children('footer')
         .first()
@@ -95,6 +95,14 @@ describe('home', () => {
         .eq(1)
         .children('a')
         .should('have.length', 2)
+        .each((el, index) => {
+          const urls = [
+            'https://next-generation-eu.europa.eu/index_fr',
+            'https://www.economie.gouv.fr/plan-de-relance',
+          ]
+          cy.wrap(el).should('have.attr', 'href', urls[index])
+          cy.wrap(el).should('have.attr', 'target', '_blank')
+        })
     })
     it('should have a button to the newsletter subscription', () => {
       cy.get('@footer')
diff --git a/libs/mel/src/lib/footer/mel-datahub-footer.component.html b/libs/mel/src/lib/footer/mel-datahub-footer.component.html
index 71911780..49f1aa48 100644
--- a/libs/mel/src/lib/footer/mel-datahub-footer.component.html
+++ b/libs/mel/src/lib/footer/mel-datahub-footer.component.html
@@ -129,14 +129,14 @@
       </ul>
     </div>
     <div class="flex flex-row items-center flex-wrap">
-      <a href="https://next-generation-eu.europa.eu/index_fr">
+      <a href="https://next-generation-eu.europa.eu/index_fr" target="_blank">
         <img
           class="h-20 mr-8"
           src="{{ iconsUrl }}finance_ue.png"
           [alt]="'mel.common.footer.logo.financeUE' | translate"
         />
       </a>
-      <a href="https://www.economie.gouv.fr/plan-de-relance">
+      <a href="https://www.economie.gouv.fr/plan-de-relance" target="_blank">
         <img
           class="h-24"
           src="{{ iconsUrl }}france_relance.png"