Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(preview sites): dropdown shows incorrect label for Optimize docs #4424

Open
pepopowitz opened this issue Oct 7, 2024 · 0 comments
Open
Assignees
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation

Comments

@pepopowitz
Copy link
Collaborator

When viewing a preview site, the dropdown shows the incorrect label when viewing Optimize docs.

In this example, the dropdown should be displaying 8.5/3.13.0 instead of 8.5:

image

This is happening because the customized NavbarItem sniffs the URL to determine if it should show the current Optimize version label in the dropdown instead of the main docs label. In a preview environment, the URL starts with the PR number (example: https://preview.docs.camunda.cloud/pr-4421/index.html). The regex expects the version number first, and doesn't match, and it always displays the main docs label.

@pepopowitz pepopowitz added the dx Documentation infrastructure typically handled by the Camunda DX team label Oct 7, 2024
@pepopowitz pepopowitz self-assigned this Oct 7, 2024
@pepopowitz pepopowitz added the kind/bug Issues related with bugs in the documentation label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation
Projects
Status: 🆕 Inbox
Development

No branches or pull requests

1 participant