Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require that the value going into a Coding's system slot is a URL #152

Open
turbomam opened this issue Nov 10, 2021 · 2 comments
Open

require that the value going into a Coding's system slot is a URL #152

turbomam opened this issue Nov 10, 2021 · 2 comments
Labels
model Issues relating to the CRDC-H model

Comments

@turbomam
Copy link
Member

No description provided.

@gaurav
Copy link
Collaborator

gaurav commented Nov 11, 2021

Yeah, it does seem strange to me that https://cancerdhc.github.io/ccdhmodel/v1.1/coding__system/ is a string rather than a URI.

@bfurner @mbrush Is there a reason for this?

@bfurner
Copy link
Contributor

bfurner commented Nov 11, 2021

i believe this was left as string since at the time we didn't have strong recommendations for how reference data like code systems should best be encoded in the model. FHIR has this as a very permissive uri type (Regex: \S*) that can be further constrained. one could obviously further constrain this to a resolvable url, but there are some source systems that may not have resolvable urls for their code systems (e.g. GDC, PDC, etc.) and when we try to encode the "original" values from the source in a Coding, we may need to accept that there are non-resolvable urls at least in the short term.

@gaurav gaurav added the model Issues relating to the CRDC-H model label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Issues relating to the CRDC-H model
Projects
None yet
Development

No branches or pull requests

3 participants