Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ongoing discussion about where to find mappings for terms as well as values #31

Open
turbomam opened this issue Nov 10, 2021 · 4 comments

Comments

@turbomam
Copy link
Member

I checked via_terminology_server.ipynb into this repo's issue-27-codable-concept-notebooks branch and created PR #28

I had two goals:

  • reimplement the GDC to CRDC-H Diagnosis conversions in GDC to CCDH conversion.ipynb to use codeable concepts instead of enumerations
  • uncouple mapping knowledge from executable code by using the CCDH terminology server. I would say that's going well for body sites and cancer stage observation values, but not for cancer stage observation types. The conversion of the GDC cancer stage observation types is currently hardcode as a bunch of if statements. I don't see how to look those up with the terminology server.
@turbomam
Copy link
Member Author

Link for terminology server: https://terminology.ccdh.io

@turbomam
Copy link
Member Author

Is there an issue anywhere for improving the terminology server's documentation? I know I've heard @joeflack4 talk about that and I would be glad to help.

@gaurav
Copy link
Collaborator

gaurav commented Nov 10, 2021

I think those are covered by:

@joeflack4
Copy link

joeflack4 commented Nov 12, 2021

There's a link to this from the GitHub home page:
https://github.com/cancerDHC/ccdh-terminology-service/blob/master/docs/rest_api.md

Only so much can fit into the swagger docs. I think I need to add more. But at least there are descriptions there now for each endpoint: https://terminology.ccdh.io/docs#


I'm still wanting to add more documentation though. Here's what I plan on adding: cancerDHC/ccdh-terminology-service#118

If you have other suggestions for what the docs should include, feel free to add there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants