Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragon quest does not advance if tabs are switched #13

Open
Raijinili opened this issue Sep 24, 2019 · 1 comment
Open

Dragon quest does not advance if tabs are switched #13

Raijinili opened this issue Sep 24, 2019 · 1 comment

Comments

@Raijinili
Copy link
Contributor

If you leave the Dragon to go to another tab, and then you go back to the MAP tab, you're stuck in place.

The reason is that the Dragon doesn't use the 10/second quest ticker, but instead makes its own interval timer to update. It is not clear why it's done this way, but the ticker is removed when the Dragon screen becomes inactive, and then it's not replaced when the screen becomes active again.

this.timerIntervalID = setInterval(this.actionInterval.bind(this), 100);

// willStopBeingDisplayed()
public willStopBeingDisplayed(): void{
clearInterval(this.timerIntervalID);
}

Should this be fixed? The other quest that uses that technique, and which also breaks, is the Tower's initial animation, but leaving the Tower lets you skip that animation anyway. I believe speedruns are not hindered by the current behavior. Tool-assisted speedruns will be, though, since in a TAS, it's possible to reach the Dragon while still needing to plant lollipops every second.

@kvaps
Copy link
Member

kvaps commented Sep 24, 2019

Hi, I'm maintainer of this project on Github, but not developer, If you consider this as bug, and if you can fix that PRs are kindly welcome :-)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants