Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove race condition between removing runner and GitHub assigning work to the runner. #31

Open
yhaliaw opened this issue Feb 9, 2023 · 1 comment
Assignees

Comments

@yhaliaw
Copy link
Collaborator

yhaliaw commented Feb 9, 2023

Enhancement Proposal

This can only happen when the number of runner is reduced via configuration, so this should be rare.

The way to resolve this will involve the GitHub runner binary having an atomic operation that checking if the runner is currently busy and remove/unregister from GitHub if not busy.

There is two way to remove/unregister a runner, one method is executing the runner binary, the other is calling a RESTful API on GitHub. From the documentation is it unclear how these two method interacts with the runner being busy.

@cbartz
Copy link
Collaborator

cbartz commented Nov 7, 2024

I think this is issue is no longer valid, can you check @yhaliaw and close, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants