[WIP] Refact/generic strategy #334
Conversation
detect if NVIDIA driver is present by the /proc/driver/nvidia/version file and: * if present, doesn't try to install * if not present, try to install using the ubuntu-drivers pkg * even if installed, the machine might require reboot. To detect this, we check if nvidia-smi command is working.
jneo8
force-pushed
the
refact/generic-strategy
branch
2 times, most recently
from
019afc4
to
482882b
Compare
- Restructure StrategyABC to have consistence interface - Remove HWToolHelper and move the logic into service layer - Change the `install` function return on BaseExporter for blocked message required - New ResourceMixin embedded into BaseExporter partial fix: canonical#272
jneo8
force-pushed
the
refact/generic-strategy
branch
from
482882b
to
3fee50a
Compare
There was a problem hiding this comment.
I believe this PR is still not done, but currently it's still not refactored enough: as you can see here, these lines are still using something outside redfish strategy line 539-641 in src/service.py
About the functions in HardwareExporter relate to Redfish, IMO they should belong to service layer because the purpose of those functions here is to generate the configuration for the hardware-exporter. We can have a discuss about to find a way to encapsulate they but it should be another refactor. The goal of this PR is about remove the |
installfunction return on BaseExporter for blocked message requiredpartial fix: #272
relate to: #333