Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA_HOME should be available from the ROCK #80

Open
zmraul opened this issue Jan 29, 2024 · 1 comment
Open

JAVA_HOME should be available from the ROCK #80

zmraul opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@zmraul
Copy link
Contributor

zmraul commented Jan 29, 2024

The charm is currently setting JAVA_HOME in /etc/environment and the Pebble layer env directly:

. . .
layer_config: pebble.LayerDict = {
            "summary": "kafka layer",
            "description": "Pebble config layer for kafka",
            "services": {
                    . . .
                    "environment": {
                        . . .
                        "JAVA_HOME": "/usr/lib/jvm/java-17-openjdk-amd64",
                        . . .
                    },
                }
            },
        }
        return Layer(layer_config)

This env should be readily available during the ROCK deployment.

Solution

  1. Add JAVA_HOME to rockcraft.yaml on kafka-rock. See ZooKeeper equivalent
  2. Remove hardcoded references to java home from the charm code.
@zmraul zmraul added the enhancement New feature or request label Jan 29, 2024
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant