Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unvendor log15 library #9726

Closed
gibmat opened this issue Dec 26, 2021 · 0 comments
Closed

Unvendor log15 library #9726

gibmat opened this issue Dec 26, 2021 · 0 comments
Assignees
Milestone

Comments

@gibmat
Copy link
Contributor

gibmat commented Dec 26, 2021

Issue description

While continuing to work on the LXD package for Debian, I noticed that there is an essentially unmodified copy of the log15 library vendored in the shared/ directory. I did find the (still open) bug about the API breakage (inconshreveable/log15#139) and commit 30c8594 that was applied to fix the build at the time.

Today I was able to successfully build LXD 4.21 with v2.15 of log15 after fixing up the imports and re-applying the commit referenced above. It seems that the log15 v2 API has remained stable for a few years now, or at least the parts of it that LXD uses. Would you consider unvendoring that code and depending on the upstream library again?

Debian packaging policy strongly frowns on vendored copies of code, especially when they're simple copies of upstream code. At the moment I've got a large (but simple) patch to remove the copy of log15 from the LXD source, but I'd prefer not to have to maintain that if we can make this change in LXD directly. :)

@stgraber stgraber self-assigned this Jan 4, 2022
@stgraber stgraber added this to the lxd-4.22 milestone Jan 4, 2022
stgraber added a commit that referenced this issue Jan 6, 2022
Closes #9726

Signed-off-by: Stéphane Graber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants