Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling primary instance handling #1138

Closed
Saviq opened this issue Oct 23, 2019 · 1 comment · Fixed by #2102
Closed

Allow disabling primary instance handling #1138

Saviq opened this issue Oct 23, 2019 · 1 comment · Fixed by #2102
Labels
enhancement good first issue help wanted
Milestone
v1.8.0

Comments

@Saviq
Copy link
Collaborator

Saviq commented Oct 23, 2019

I'm unlikely to ever want a primary instance as an Ubuntu user (if
there's something that I just want a pet Ubuntu instance for, I have my
desktop; anything more specific and I'm going to want to choose the
Ubuntu release I launch); is there any way I can configure multipass to
disable this behaviour?

Originally posted by @OddBloke in #1133 (comment)
@Saviq
Copy link
Collaborator Author

Saviq commented Oct 23, 2019

I propose accepting multipass set client.primary-name= to set it to null and then handling that appropriately wherever it has special handling.

@surahman surahman mentioned this issue May 12, 2021
Merged
@Saviq Saviq linked a pull request Jun 23, 2021 that will close this issue
[cli] Toggle Primary Instance (petenv) #2102
Merged
bors bot added a commit that referenced this issue Aug 4, 2021
@bors @surahman
Merge #2102
5d62046 
2102: [cli] Toggle Primary Instance (petenv) r=ricab a=surahman

**_Issue #1138:_**
I have added support to handle the `client.primary-name=` command. I am not sure about the mock tests I have set up and they would require some review. When stepping through the tests with a debugger I was unable to hit breakpoints on `set` and `set_aux` within the `utils/settings.cpp` file - which is typically an indicator of an issue. Manual argument passing tests work on the `cmdl`.

Co-authored-by: Saad Ur Rahman <[email protected]>
bors bot added a commit that referenced this issue Aug 4, 2021
@bors @surahman
Merge #2102
2131e05 
2102: [cli] Toggle Primary Instance (petenv) r=ricab a=surahman

**_Issue #1138:_**
I have added support to handle the `client.primary-name=` command. I am not sure about the mock tests I have set up and they would require some review. When stepping through the tests with a debugger I was unable to hit breakpoints on `set` and `set_aux` within the `utils/settings.cpp` file - which is typically an indicator of an issue. Manual argument passing tests work on the `cmdl`.

Co-authored-by: Saad Ur Rahman <[email protected]>
bors bot added a commit that referenced this issue Aug 5, 2021
@bors @surahman
Merge #2102
a130207 
2102: [cli] Toggle Primary Instance (petenv) r=ricab a=surahman

**_Issue #1138:_**
I have added support to handle the `client.primary-name=` command. I am not sure about the mock tests I have set up and they would require some review. When stepping through the tests with a debugger I was unable to hit breakpoints on `set` and `set_aux` within the `utils/settings.cpp` file - which is typically an indicator of an issue. Manual argument passing tests work on the `cmdl`.

Co-authored-by: Saad Ur Rahman <[email protected]>
@bors bors bot closed this as completed in #2102 Aug 5, 2021
@Saviq Saviq added this to the v1.8.0 milestone Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

[cli] Toggle Primary Instance (petenv)
1 participant
@Saviq