Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Qt6 #2627

Closed
yogurtearl opened this issue Jun 21, 2022 · 17 comments · Fixed by #2782
Closed

Update to Qt6 #2627

yogurtearl opened this issue Jun 21, 2022 · 17 comments · Fixed by #2782
Assignees
Milestone

Comments

@yogurtearl
Copy link

yogurtearl commented Jun 21, 2022

Update to use QT 5.15.5 5.15.3 or later
https://www.qt.io/blog/commercial-lts-qt-5.15.5-released

Contains a fix for this proxy issue:
#2325 (comment)

@minhio
Copy link

minhio commented Aug 11, 2022

@townsend2010
Copy link
Contributor

Yes, we can update to this version on Windows and macOS, but on Linux, it's more tricky. When building the Multipass snap with the core20 base, we are stuck at Qt version 5.12.8. If we were to move to the core22 base, we then get Qt version 5.15.3, so still not new enough. Qt6 is available when using the core22 base but switching over all of our Qt code to use Qt6 will be a fairly big effort.

@minhio
Copy link

minhio commented Aug 11, 2022

Yes, we can update to this version on Windows and macOS, but on Linux, it's more tricky. When building the Multipass snap with the core20 base, we are stuck at Qt version 5.12.8. If we were to move to the core22 base, we then get Qt version 5.15.3, so still not new enough. Qt6 is available when using the core22 base but switching over all of our Qt code to use Qt6 will be a fairly big effort.

@townsend2010 thank you for the update/context

@yogurtearl
Copy link
Author

@townsend2010 just updating on Windows and macOS would be a great help for us.
This is a hard showstopper for us using multipass, and I haven't found a workaround. :/

@minhio
Copy link

minhio commented Aug 11, 2022

@townsend2010 just updating on Windows and macOS would be a great help for us. This is a hard showstopper for us using multipass, and I haven't found a workaround. :/

ditto

@yogurtearl
Copy link
Author

Looks like 5.15.10 is out.

https://www.qt.io/blog/commercial-lts-qt-5.15.10-released

@townsend2010
Copy link
Contributor

Hi @yogurtearl and @minhio,

What platforms are you using Multipass on? If it's not Linux, then we can address this. On Linux, we are just constrained by what the Ubuntu archive provides for the Qt version without a bunch of heavy lifting on our part such as the aforementioned move to core22/Qt6 or building Qt from source.

@minhio
Copy link

minhio commented Aug 11, 2022

Hi @yogurtearl and @minhio,

What platforms are you using Multipass on? If it's not Linux, then we can address this. On Linux, we are just constrained by what the Ubuntu archive provides for the Qt version without a bunch of heavy lifting on our part such as the aforementioned move to core22/Qt6 or building Qt from source.

I'm on a M1 Mac 🤞🙏

@yogurtearl
Copy link
Author

Well... so far we aren't using it, because of #2325 😅

Our potential use case would be for Windows and macOS (both Intel and Apple Silicon).

@yogurtearl
Copy link
Author

yogurtearl commented Aug 11, 2022

If we were to move to the core22 base, we then get Qt version 5.15.3, so still not new enough.

Actually I think this could work for core22 as well.

Looks like 5.15.3 contained the needed fix (I just updated the issue description):

https://invent.kde.org/qt/qt/qtbase/-/blob/c8989ca20fa5798f7853f07df6e150cc407c64a4/src/network/kernel/qnetworkproxy_mac.cpp#L211

@yogurtearl yogurtearl changed the title Update to QT 5.15.5 Update to QT 5.15.3 or later Aug 11, 2022
@yogurtearl yogurtearl changed the title Update to QT 5.15.3 or later Update to QT ~5.15.5~ 5.15.3 or later Aug 11, 2022
@yogurtearl yogurtearl changed the title Update to QT ~5.15.5~ 5.15.3 or later Update to QT 5.15.3 or later Aug 11, 2022
@townsend2010
Copy link
Contributor

Oh, I see, those newer versions are commercial versions which we are not using. We use the fully open source version which is currently 5.15.2. We need to wait for Qt to release a newer open source version before we can get this in Qt5. If we were to do this today, we'd need to move to Qt6.

@townsend2010
Copy link
Contributor

Well, after I said that, I looked at what brew provides and it's 5.15.5, so maybe there is hope. I need to dig a little further.

@yogurtearl
Copy link
Author

@yogurtearl
Copy link
Author

Also, Arch Linux has 5.15.5:
https://archlinux.org/packages/extra/x86_64/qt5-base/

@minhio
Copy link

minhio commented Aug 25, 2022

Well, after I said that, I looked at what brew provides and it's 5.15.5, so maybe there is hope. I need to dig a little further.

@townsend2010 thoughts on if 5.15.5 will make it into any of the upcoming windows/macos release? thanks!

@townsend2010
Copy link
Contributor

Hey @minhio,

Yeah, I'm targeting that version for Multipass 1.11 on Windows & macOS only at this time.

@minhio
Copy link

minhio commented Aug 25, 2022

Hey @minhio,

Yeah, I'm targeting that version for Multipass 1.11 on Windows & macOS only at this time.

@andrei-toterman andrei-toterman self-assigned this Oct 17, 2022
@townsend2010 townsend2010 changed the title Update to QT 5.15.3 or later Update to Qt6 Feb 8, 2023
@townsend2010 townsend2010 linked a pull request Feb 8, 2023 that will close this issue
@townsend2010 townsend2010 added this to the 1.12.0 milestone Feb 8, 2023
@townsend2010 townsend2010 modified the milestones: 1.12.0, 1.13.0 Feb 14, 2023
bors bot added a commit that referenced this issue Jul 24, 2023
2782: Update to qt6 r=townsend2010 a=andrei-toterman

Fixes #2627

Co-authored-by: Andrei Toterman <[email protected]>
townsend2010 added a commit that referenced this issue Jul 24, 2023
2782: Update to qt6 r=townsend2010 a=andrei-toterman

Fixes #2627

Co-authored-by: Andrei Toterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants