Show in-app notification if an update is available #3621
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
- Coverage 88.86% 88.85% -0.01%
==========================================
Files 254 254
Lines 14266 14269 +3
==========================================
+ Hits 12677 12679 +2
- Misses 1589 1590 +1 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
update-available-notif
branch
from
8420eaf
to
145e60c
Compare
There was a problem hiding this comment.
Tested and I see the update notification. However, it only shows up on launching the GUI. If I leave the GUI running long enough for DefaultUpdatePrompt::is_time_to_show() to return true again, I don't get another notification telling me about a newer version.
|
As a follow-up, I'm not sure which is the preferred behaviour. Showing an update notification once on launch, or as per the update prompt timer. Multipass doesn't update that often so getting "live" update notifications might not be an issue. |
|
Live notifications would be better, to quickly get to people who just suspend their laptop and keep the GUI running. |
the notifier makes sure that, if needed, only one update notification is on screen for a given version
andrei-toterman
force-pushed
the
update-available-notif
branch
from
145e60c
to
6a3f021
Compare
|
@sharder996 sorry to bother, but I just realized I was over-complicating things a little when extracting the update info from the rpc reply, so I pushed an update. Again, sorry for interrupting the merge 😅 |
This PR adds a notification if there is a Multipass update available.
There is also a refactoring for the update entry in the settings page.