Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formik error when using latest version in project #1069

Open
steverydz opened this issue Apr 16, 2024 · 4 comments
Open

Formik error when using latest version in project #1069

steverydz opened this issue Apr 16, 2024 · 4 comments
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@steverydz
Copy link
Contributor

When using the latest version (0.51.4) of this package in a project, e.g. charmhub.io, the following error occurs, preventing the project from building:

ERROR in ./node_modules/@canonical/react-components/dist/components/FormikField/FormikField.js 8:14-31
Module not found: Error: Can't resolve 'formik' in '/home/ubuntu/charmhub-io/node_modules/@canonical/react-components/dist/components/FormikField'
@andesol
Copy link
Contributor

andesol commented Apr 18, 2024

I've got a similar one:

Uncaught TypeError: The specifier “formik” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”.

Seems like formik has been added recently and it's not listed as a dependency in the package.json, but as a dev and peer dependencies. The problem disappeared when I installed it in my project.

@bartaz
Copy link
Member

bartaz commented Sep 30, 2024

Triage: we need to decide how to deal with that. If formik is used internally it probably needs to be a dependency.

@bartaz bartaz added the P3 Needs decision Needs team agreement in terms of triaging. label Sep 30, 2024
@huwshimi
Copy link
Collaborator

huwshimi commented Oct 3, 2024

Maybe we should move Formik to optional deps. I think it's only used by one component at the moment.

@bartaz bartaz added Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 and removed P3 Needs decision Needs team agreement in terms of triaging. labels Oct 24, 2024
@bartaz
Copy link
Member

bartaz commented Oct 24, 2024

Using optional dependencies would likely be a bit of a hussle, as we would need to handle it properly in the code for cases when formik is not avaialble (https://docs.npmjs.com/cli/v8/configuring-npm/package-json#optionaldependencies)

Maybe the easiest solution would be to actually move it to dependences, if it is now required for components to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

4 participants