Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinning animation in ActionButton ends too late #1109

Open
lorumic opened this issue Jul 25, 2024 · 2 comments
Open

Spinning animation in ActionButton ends too late #1109

lorumic opened this issue Jul 25, 2024 · 2 comments
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@lorumic
Copy link
Contributor

lorumic commented Jul 25, 2024

When using ActionButton with the loading and disabled props, the spinning animation ends later than when the variable regulating the loading behaviour is set to false:

            <ActionButton
              disabled={isLoading}
              loading={isLoading}
              className="u-no-margin--bottom"
              onClick={handleGenerate}
            >
              Request new URL
            </ActionButton>

Peek 2024-07-25 20-30

As can be seen in the screen capture, the cursor gets switched back to the pointer value (= enabled state) while the spinning animation is still showing.

@bartaz
Copy link
Member

bartaz commented Sep 30, 2024

Not sure if that's the issue with the component itself, or the application, or React rendering.
All the button is doing is rendering itself based on props passed. So some more debugging may be needed to understand why they appear to change at different times.

@bartaz bartaz added the P3 Needs decision Needs team agreement in terms of triaging. label Sep 30, 2024
@bartaz bartaz added Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 and removed P3 Needs decision Needs team agreement in terms of triaging. labels Oct 24, 2024
@bartaz
Copy link
Member

bartaz commented Oct 24, 2024

It's relevant in current architecture (bug in existing component). It's not trivial to reproduce and debug though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

2 participants