Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing lodash/isEqual dep #990

Closed
huwshimi opened this issue Oct 25, 2023 · 3 comments · Fixed by #993
Closed

Missing lodash/isEqual dep #990

huwshimi opened this issue Oct 25, 2023 · 3 comments · Fixed by #993
Assignees
@huwshimi
Labels
Bug 🐛 Something isn't working released

Comments

@huwshimi
Copy link
Collaborator

This package now requires lodash/isEqual but it is not included in the deps.
@huwshimi huwshimi added the Bug 🐛 Something isn't working label Oct 25, 2023
@akmittal
Copy link
Contributor

akmittal commented Nov 15, 2023 •
edited
Loading

This looks like a small change. Everything seem to work because lodash is still there as dependency of other packages.
There also can be a eslint rule(eslint-plugin-implicit-dependencies) to prevent this in future.

Can I work on this?

@huwshimi huwshimi mentioned this issue Nov 15, 2023
Merged
@huwshimi huwshimi self-assigned this Nov 15, 2023
@huwshimi
Copy link
Collaborator Author

Can I work on this?

@akmittal thanks for asking, but I actually created a PR for this, but forgot to assign and link this issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

🎉 This issue has been resolved in version 0.50.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huwshimi huwshimi

Labels
Bug 🐛 Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): Added missing lodash/isequal dep huwshimi/react-components
2 participants
@huwshimi @akmittal