Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename references to "PIN" to "passphrase" #113

Closed
chrisccoulson opened this issue Sep 23, 2020 · 2 comments
Closed

Rename references to "PIN" to "passphrase" #113

chrisccoulson opened this issue Sep 23, 2020 · 2 comments

Comments

@chrisccoulson
Copy link
Collaborator

The PIN can be an arbitrary passphrase - nowhere is it enforced that it is actually a PIN. Whilst consumers of this package could enforce this, we don't and so references to "PIN" should just be renamed to "passphrase" everywhere it appears.
@pedronis
Copy link
Collaborator

Given that we need to abstract over things in one way or another in crypt.go. We can probably start there by renaming "PIN" to "UserPassphrase" in that context. Renaming PIN in the context of the TPM specific code is more involved, there's even a file called pin.go atm.

pedronis added a commit that referenced this issue Sep 25, 2020
@pedronis
Have a single ActivateVolumeOptions struct for the ActivateVolumeWith…
fbec76e 
…* funcs

Also rename PIN in its definition to UserPassprase to move toward
better and also more abstract naming.

Same in the corresponding RecoveryKeyUsageReason code.

Se also issue #113
@pedronis pedronis mentioned this issue Sep 25, 2020
Merged
pedronis added a commit that referenced this issue Sep 25, 2020
@pedronis
Have a single ActivateVolumeOptions struct for the ActivateVolumeWith…
70fb38d 
…* family

Merge pull request #116 from snapcore/activate-volume-options

Also rename PIN in its definition to Passphrase to move toward
better and also more abstract naming.

Same in the corresponding RecoveryKeyUsageReason code.

See also issue #113
@chrisccoulson
Copy link
Collaborator Author

Closing this one now given that secboot is going to be treating PINs and passphrases as separate user authentication mechanisms, so both terms will exist but refer to different things. The repo today supports passphrases. #289 will introduce PINs, once it's rebased and has tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisccoulson @pedronis