diff --git a/templates/_macros/vf_hero.jinja b/templates/_macros/vf_hero.jinja
index ce9df4868..6d5c14967 100644
--- a/templates/_macros/vf_hero.jinja
+++ b/templates/_macros/vf_hero.jinja
@@ -1,6 +1,6 @@
# Params
-# title: Hero title text (required)
-# subtitle: Hero subtitle text
+# title_text: Hero title text (required)
+# subtitle_text: Hero subtitle text
# layout: layout of hero section. Options are '50/50', '50/50-full-width-image', '75/25', '25/75', 'fallback'
# is_split_on_medium: whether the layout is split on tablet in 50/50, 25/75, and 75/25 layouts.
# If false, the layout is stacked on tablet.
@@ -11,12 +11,12 @@
# image: slot for image content
# signpost_image: slot for signpost (left column) image content in 25/75 layout. Required for 25/75 layout.
{% macro vf_hero(
- title,
- subtitle='',
+ title_text,
+ subtitle_text='',
layout="fallback",
is_split_on_medium=false
) -%}
- {% set has_subtitle = subtitle|trim|length > 0 %}
+ {% set has_subtitle = subtitle_text|trim|length > 0 %}
{% set description_content = caller('description') %}
{% set has_description = description_content|trim|length > 0 %}
{% set cta_content = caller('cta') %}
@@ -77,22 +77,25 @@
{% set title_class = "u-no-margin--bottom" %}
{%- endif -%}
+
{#- Only add a class attribute if needed -#}
0 %} class="{{ title_class }}"{% endif %}>
- {{ title }}
+ {{ title_text }}
{%- endmacro %}
{%- macro _hero_subtitle_block() -%}
{% if has_subtitle %}
+
- {{ subtitle }}
+ {{ subtitle_text }}
{% endif %}
{%- endmacro %}
{%- macro _hero_cta_block() -%}
{% if has_cta -%}
+
{{ cta_content }}
@@ -101,6 +104,7 @@
{%- macro _hero_description_block() -%}
{% if has_description %}
+
{{ description_content }}
@@ -109,6 +113,7 @@
{%- macro _hero_signpost_image_block() -%}
{% if layout == '25-75' and has_signpost_image -%}
+
{{ signpost_image_content }}
@@ -127,12 +132,13 @@
{% endif -%}
- {%- if is_fallback %}
+ {%- if is_fallback -%}
{{- _hero_description_block() -}}
{{ _hero_cta_block() -}}
{% if has_image -%}
+
{{ image_content }}
@@ -148,6 +154,7 @@
{{- _hero_description_block() -}}
{{- _hero_cta_block() -}}
+
{{ image_content -}}
{% elif has_signpost_image %}
{#- 25/75 Signpost layout -#}
@@ -164,6 +171,7 @@
{% if has_image %}
{#- Signpost with image is always full-width, so set it after the columns -#}
+
{{- image_content }}
{% endif -%}
{% else %}
@@ -176,6 +184,7 @@
{{- _hero_cta_block() -}}
{% if has_image -%}
+
{{ image_content }}
diff --git a/templates/docs/examples/patterns/hero/hero-50-50-split-on-medium.html b/templates/docs/examples/patterns/hero/hero-50-50-split-on-medium.html
index d455bde4b..27d483f23 100644
--- a/templates/docs/examples/patterns/hero/hero-50-50-split-on-medium.html
+++ b/templates/docs/examples/patterns/hero/hero-50-50-split-on-medium.html
@@ -8,8 +8,8 @@
{% block content %}
{% call(slot) vf_hero(
- title='H1 - ideally one line, up to two',
- subtitle='H2 placeholder - aim for one line, 2 is acceptable, more - use a paragraph',
+ title_text='H1 - ideally one line, up to two',
+ subtitle_text='H2 placeholder - aim for one line, 2 is acceptable, more - use a paragraph',
layout='50/50',
is_split_on_medium=true
) -%}