-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to pagination #4704
Comments
Thanks @al-bakalova, could you add some screenshots to the description? It makes it easier to understand what it's about without clicking on all the links. |
@dgtlntv Can you add some interaction images for the pagination in the description here as well? 😃 |
FYI: @ndv99 Worked on the implementation for MAAS! |
Not sure how much help this might be but here's the SCSS I wrote for it: .p-pagination--items {
padding-bottom: $spv--small;
.p-button {
margin: 0;
border: 0;
}
.p-pagination__link--next {
margin-right: $spv--large * 2;
}
.p-pagination__input {
margin: 0 $spv--small;
appearance: none;
width: 3rem;
min-width: 0;
text-align: center;
}
// required to get rid of buttons/arrows while keeping number-only input
input::-webkit-outer-spin-button,
input::-webkit-inner-spin-button {
appearance: none;
}
input[type=number] {
appearance: textfield;
}
} |
@al-bakalova and @juanruitina to do some benchmarking, and propose a mini spec explaining when to use which version and which exact versions are being proposed. |
@AnnSoMuller to link to an example spec here |
Sure. |
Not sure if still relevant, but we used to have a minimal pagination proposal like that before (via #3649):
Not sure if it's still being used, should it be considered as variant, or is it replaced by other styles of pagination already. |
Another pagination related discussion about positioning of pagination: #3208 |
Table Pagination has been recently added to React components: canonical/react-components#1013 Are we ready to build this into Vanilla, does it need any more design work? @danielmutis @juanruitina ? |
Alex and I did some benchmarking around this. The React implementation seems to work good enough for tables, although I'd suggest one change: I'd rather have a clear label for the "Items per page" selector: having "/page" as part of each option feels awkward and would result in weird output from screen readers. Something like this (quick mockup, selector as compact as possible): On Sites we tend to mention the number of search results at the top, then have the standard pagination at the bottom left and results per page at the bottom right. I understand this could still be an option, am I right? |
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15225.
|
Following up on the comment @juanruitina made, this is how it looks in patternfly (https://staging-v6.patternfly.org/components/pagination): I find this takes up less space than "Items per page: " as label and exposes more information. |
Pattern to amend
Table controls
Visual
MAAS
LXD
Context
MAAS has recently introduced a table control bar. It consists of the following three elements:
To meet our user's needs, as well as to keep the experience across products consistent, the LDX team has decided to adopt the pattern.
To meet the needs of the MAAS user, the table control bar is positioned above the table.
To meet the needs of the LXD users, the table control bar is positioned below the table, as a sticky table footer.
(see mockups in Zeplin)
Links to the GitHub tasks (MAAS)
Page size select
Pagination
We believe other products can benefit from this pattern.
The text was updated successfully, but these errors were encountered: