Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation dropdowns do not report expanded/collapsed state #5203

Open
jmuzina opened this issue Jul 1, 2024 · 2 comments
Open

Navigation dropdowns do not report expanded/collapsed state #5203

jmuzina opened this issue Jul 1, 2024 · 2 comments
Labels
Accessibility Bug 🐛 P3 Needs decision Needs team agreement in terms of triaging.

Comments

@jmuzina
Copy link
Member

jmuzina commented Jul 1, 2024

Describe the bug

Navigation dropdowns do not report expanded/collapsed state.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://vanillaframework.io/docs/examples/patterns/navigation/dropdown-dark?theme=light
  2. Observe that the nested p-navigation__item--dropdown-toggle elements do not have aria-expanded attribution on them.
  3. Install a screen reader
  4. Access the above navigation bar using keyboard controls, and tab over the navigation dropdowns.
  5. Verify that the screen reader does not report expanded/collapsed state.

Expected behavior

The navigation dropdown links report expanded/collapsed state to screen readers. Tabbing over them should report "button collapsed" or something similar. Expanding/collapsing them should also report the change to the screen reader.

See https://getbootstrap.com/docs/4.0/components/navbar/ for example.

Desktop (please complete the following information):

  • OS: PopOS 22.04
  • Browser Chrome
  • Version 125.0.6422.141 x64

Additional context

This was noticed during work on reduced top-nav, but effects all vanilla navigation.

@bartaz
Copy link
Member

bartaz commented Sep 25, 2024

Triage: this has quite high impact on accessibility, but may be quite high effort as well (and rely on JS that will not be easily updated downstream).

To be discussed with team if we want to address it in current codebase.

@bartaz bartaz added the P3 Needs decision Needs team agreement in terms of triaging. label Sep 25, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15289.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Bug 🐛 P3 Needs decision Needs team agreement in terms of triaging.
Projects
None yet
Development

No branches or pull requests

2 participants