Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement: Clarify best practices #5369

Open
jmuzina opened this issue Oct 4, 2024 · 1 comment
Open

Documentation improvement: Clarify best practices #5369

jmuzina opened this issue Oct 4, 2024 · 1 comment
Labels
Documentation 📝 Documentation changes or updates P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@jmuzina
Copy link
Member

jmuzina commented Oct 4, 2024

During a recent conversation with @mtruj013 I was told that our documentation is used by sites devs as a source of truth for best practices on using Vanilla. However there are some best practices that are not documented on our site, and are only spread by word-of-mouth through code reviews.

A frequent sticking point in code reviews is the mixing of component class names, like this:

<div class="row p-section"

This makes code a bit harder to read, and also increases changes of issues like this happening.

We should make it clearer in the docs (or somewhere else?) that this is discouraged. There are likely other best practices that we can add there, so this issue can stand as an open discussion of what best practices are currently unwritten and only coming up in code review. This way, our best practices can be codified, rather than existing as "rumors".

@jmuzina jmuzina added the WG: Proposal Working group proposals label Oct 4, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15628.

This message was autogenerated

@bartaz bartaz added Documentation 📝 Documentation changes or updates P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 and removed WG: Proposal Working group proposals labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📝 Documentation changes or updates P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

2 participants