Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASWebAuthenticationSession Support? #122

Open
xcskier56 opened this issue Oct 14, 2020 · 7 comments
Open

ASWebAuthenticationSession Support? #122

xcskier56 opened this issue Oct 14, 2020 · 7 comments
Labels
enhancement New feature or request ios

Comments

@xcskier56
Copy link

Description

Does this plugin support using ASWebAuthenticationSession? I know that OauthSwift, which this plugin is using does, but in my testing, it seems that a regular Safari View is used instead of the ASWebauthenticationSession. I'm a web dev so only moderately understand the swift code, but it appears to me that a SafariURLHandler is being used instead of the ASWebauthenticationSession. Is this the case?

@phal0r
Copy link

phal0r commented Sep 3, 2021

What is the advantage of ASWebAuthenticationSession @xcskier56 ?

@moberwasserlechner
Copy link
Collaborator

I for my part can not answer this question either.

@xcskier56 please explain the advantages of ASWebAuthenticationSession.

I keep this issue open a few days and close it afterwards if there is no feedback.

BR

@moberwasserlechner moberwasserlechner added needs-reply The author needs to reply to questions. Task will be closed after 5days if not answered. question Support and removed support labels Sep 30, 2021
@phal0r
Copy link

phal0r commented Oct 20, 2021

I did some investigation and ASWebAuthenticationSession should be used as it is more secure and provides better usability by sharing cookies and password autocompletion.

See: https://authguidance.com/2020/02/22/ios-code-sample-overview/

Also, I think it is correct, that OauthSwift has support for ASWebAuthenticationSession and this should be the default way to initialize a OAuth2/OIDC Login.

Can this somehow be made configurable @moberwasserlechner ?

@moberwasserlechner moberwasserlechner added enhancement New feature or request and removed needs-reply The author needs to reply to questions. Task will be closed after 5days if not answered. labels Jan 6, 2022
@moberwasserlechner moberwasserlechner added this to the 3.0.2 milestone Jan 6, 2022
@moberwasserlechner moberwasserlechner removed the question Support label Jan 7, 2022
@doublechecker
Copy link

Hey there. This is quite important because we already had some trouble with Apple App Review. Sometimes they reject our app because we do not use the desired way of ASWebAuthenticationSession. When ASWebAuthenticationSession is used there is an alert asking the user if the app should open a authentication-session (see screenshot as example). We would really appreciate this feature as it is implemented in the underlying plugin already.
33736712-3d3deaf4-db59-11e7-9336-552df2fc092d

@LucaBlackDragon
Copy link

moreover, this feature would allow to achieve Single Sign On between two or more different apps (provided they all talk to the same OIDC provider)

@sampaxk
Copy link

sampaxk commented Jan 17, 2023

I've created a pull request that allows the plugin to support ASWebAuthenticationSession.
Here is it: #226

@moberwasserlechner moberwasserlechner removed this from the 3.0.2 milestone Apr 11, 2023
@otrebu
Copy link

otrebu commented Jun 5, 2024

Just wondering why the PR it is not merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ios
Projects
None yet
Development

No branches or pull requests

7 participants