From 425ee80414b4a67812a2a917a7cc675a1153a05b Mon Sep 17 00:00:00 2001
From: Arief Rahmansyah <ariefrahmansyah@hotmail.com>
Date: Thu, 29 Apr 2021 12:14:18 +0700
Subject: [PATCH] Fix collapsible nav props (#18)

* Fix collapsible nav props

* Bump to 1.4.1
---
 ui/package.json                               |  2 +-
 ui/packages/app/package.json                  |  4 +-
 ui/packages/lib/package.json                  |  2 +-
 .../src/components/nav_drawer/NavDrawer.js    | 39 +++++++++----------
 4 files changed, 22 insertions(+), 25 deletions(-)

diff --git a/ui/package.json b/ui/package.json
index 3d5fb479..886ebedd 100644
--- a/ui/package.json
+++ b/ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gojek/mlp-ui",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "private": true,
   "repository": {
     "type": "git",
diff --git a/ui/packages/app/package.json b/ui/packages/app/package.json
index bac55259..48470064 100644
--- a/ui/packages/app/package.json
+++ b/ui/packages/app/package.json
@@ -1,12 +1,12 @@
 {
   "name": "mlp-ui",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "private": true,
   "license": "Apache-2.0",
   "dependencies": {
     "@elastic/datemath": "5.0.3",
     "@elastic/eui": "31.10.0",
-    "@gojek/mlp-ui": "1.4.0",
+    "@gojek/mlp-ui": "1.4.1",
     "@reach/router": "1.3.3",
     "@sentry/browser": "5.15.5",
     "moment": "2.25.3",
diff --git a/ui/packages/lib/package.json b/ui/packages/lib/package.json
index 9dac8326..d84ecf51 100644
--- a/ui/packages/lib/package.json
+++ b/ui/packages/lib/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gojek/mlp-ui",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "license": "Apache-2.0",
   "main": "dist/index.js",
   "module": "dist/index.es.js",
diff --git a/ui/packages/lib/src/components/nav_drawer/NavDrawer.js b/ui/packages/lib/src/components/nav_drawer/NavDrawer.js
index 1d5a5367..e8c3f54f 100644
--- a/ui/packages/lib/src/components/nav_drawer/NavDrawer.js
+++ b/ui/packages/lib/src/components/nav_drawer/NavDrawer.js
@@ -9,8 +9,7 @@ import {
   EuiHeaderSectionItemButton,
   EuiIcon,
   EuiFlexItem,
-  EuiSpacer,
-  EuiShowFor
+  EuiSpacer
 } from "@elastic/eui";
 import ApplicationsContext from "../../providers/application/context";
 import { CurrentProjectContext } from "../../providers/project";
@@ -68,7 +67,7 @@ export const NavDrawer = ({ homeUrl = "/", docLinks }) => {
         <EuiFlexItem grow={true}>
           {mlpLinks.length > 0 && (
             <EuiCollapsibleNavGroup
-              isCollapsible={false}
+              isCollapsible={true}
               initialIsOpen={appExpanded}
               onToggle={toggleAppExpanded}
               iconType="apps"
@@ -88,7 +87,7 @@ export const NavDrawer = ({ homeUrl = "/", docLinks }) => {
             <EuiCollapsibleNavGroup
               title="Learn"
               iconType="training"
-              isCollapsible={false}
+              isCollapsible={true}
               initialIsOpen={docsExpanded}
               onToggle={toggleDocsExpanded}>
               <EuiListGroup
@@ -120,23 +119,21 @@ export const NavDrawer = ({ homeUrl = "/", docLinks }) => {
         <EuiHorizontalRule margin="none" />
 
         <EuiFlexItem grow={false}>
-          <EuiShowFor sizes={["l", "xl"]}>
-            <EuiCollapsibleNavGroup>
-              <EuiListGroupItem
-                size="s"
-                color="subdued"
-                label={`${navIsDocked ? "Undock" : "Dock"} navigation`}
-                onClick={() => {
-                  setNavIsDocked(!navIsDocked);
-                  localStorage.setItem(
-                    'mlp-navIsDocked',
-                    JSON.stringify(!navIsDocked)
-                  );
-                }}
-                iconType={navIsDocked ? "lock" : "lockOpen"}
-              />
-            </EuiCollapsibleNavGroup>
-          </EuiShowFor>
+          <EuiCollapsibleNavGroup>
+            <EuiListGroupItem
+              size="s"
+              color="subdued"
+              label={`${navIsDocked ? "Undock" : "Dock"} navigation`}
+              onClick={() => {
+                setNavIsDocked(!navIsDocked);
+                localStorage.setItem(
+                  'mlp-navIsDocked',
+                  JSON.stringify(!navIsDocked)
+                );
+              }}
+              iconType={navIsDocked ? "lock" : "lockOpen"}
+            />
+          </EuiCollapsibleNavGroup>
         </EuiFlexItem>
       </EuiFlexGroup>
     </EuiCollapsibleNav>