CARAPACE_MATCH doesn't ignore case on completion

[houqp]

Current Behavior

when CARAPACE_MATCH is set to 1, trying to complete with pkill --signal a yields no result

Expected Behavior

when CARAPACE_MATCH is set to 1, trying to complete with pkill --signal a yields:

ABRT  -- Abnormal termination
ALRM  -- Virtual alarm clock

Steps To Reproduce

1. set CARAPACE_MATCH to 1
2. type pkill --signal a
3. press tab to trigger completion

Version

1.0.7

OS

• Darwin
• Linux
• Termux
• Windows

Shell

• Bash
• Elvish
• Fish
• Nushell
• Oil
• Powershell
• Xonsh
• Zsh

Anything else?

Not the root cause of this since the example uses prefix for completion, but there seems be to another bug in the relevant code file:

carapace/pkg/match/match.go

Line 18 in 49b6747

strings.EqualFold(s, t)

. We are not returning the result from strings.EqualFold when CASE_INSENSITIVE is enabled.

Polar

[rsteube]

You also need to configure your shell for case insensitive matching: https://superuser.com/a/1092328 .
Otherwise it filters out the the values provided by carapace.
(i should add documentation for that)

[houqp]

Thanks for the quick response, can confirm this fixes my issue 👍 Agreed that it would be very helpful to add this to the doc.