Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture specific exception types in except #40

Open
JPTIZ opened this issue Sep 12, 2022 · 0 comments
Open

Capture specific exception types in except #40

JPTIZ opened this issue Sep 12, 2022 · 0 comments

Comments

@JPTIZ
Copy link
Member

JPTIZ commented Sep 12, 2022

Some exception handling code take the generic type Exception in except and, in a couple cases:

if isinstance(exc, telegram.error.BadRequest):

if isinstance(exc, telegram.error.BadRequest):

if isinstance(exc, telegram.error.BadRequest):

And, after #34 is merged:

if isinstance(exc, VideoTooLongError):

So instead of doing:

except Exception as exc:
    if isinstance(exc, SpecificType):

We should slightly rework the code to get exceptions as:

except SpecificType as error:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant