Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Charts Modal is not appending to body please use react portals #1241

Open
Likith-Chintala opened this issue Dec 10, 2021 · 3 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@Likith-Chintala
Copy link

Contact Details

No response

What happened?

A bug happened!

Version

latest

Data & options used

No response

Relevant log output

No response

Codesandbox example

No response

@Likith-Chintala Likith-Chintala added the type: bug 🐛 Something isn't working label Dec 10, 2021
@Akshat55
Copy link
Collaborator

Hi, we are going to need more information on this. Have you imported the css? What version of react are you using? Could you please provide us with a code sandbox?

Based on this example code sandbox, we can see that they are being appended to the body.

https://codesandbox.io/s/06m3t

@rwibm
Copy link

rwibm commented Dec 1, 2023

I'm not sure why this issue is asking for more information but this is definitely still a problem with the latest charts, even in the code sandbox linked above the modal is clearly not inserted as a direct child of the body element.

Modals are completely broken if any parent element of the "chart-holder" div (where the modal is inserted in the DOM) has a relative position or has "transform: translate" applied to it.

Like the OP said, can this be changed to use React portals please so modals work as expected?

@theiliad
Copy link
Member

theiliad commented Dec 9, 2023

Hi @rwibm, our React components are merely wrappers of the vanilla implementation. We're not able to use React portals for that reason. However I do think the ask here is a valid one, I will try to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

4 participants