Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility toolbar btn #1560 #1677

Merged

Conversation

RiyaJethwa
Copy link
Contributor

@RiyaJethwa RiyaJethwa commented Oct 18, 2023

Updates

  • #1560
    -Chart toolbar buttons were enclosed in div with a role of button
    -Issue fixed by removing said role

Demo screenshot or recording

image

@RiyaJethwa RiyaJethwa requested review from theiliad and a team as code owners October 18, 2023 12:39
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 57455e4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/652fd4fc321c7a0009a85eb9
😎 Deploy Preview https://deploy-preview-1677--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 57455e4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/652fd4fcacdac3000851ff22
😎 Deploy Preview https://deploy-preview-1677--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 57455e4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/652fd4fc4719970008945595
😎 Deploy Preview https://deploy-preview-1677--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RiyaJethwa
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@theiliad theiliad merged commit fe0f8ca into carbon-design-system:master Nov 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants