Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@carbon/charts-react Storybook builds use vite instead of webpack, fixed minor Storybook CSS issue causing warnings in console, bumped dependencies, docs cleanup #1691

Merged
merged 30 commits into from
Dec 18, 2023
Merged

@carbon/charts-react Storybook builds use vite instead of webpack, fixed minor Storybook CSS issue causing warnings in console, bumped dependencies, docs cleanup #1691

merged 30 commits into from
Dec 18, 2023

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Nov 29, 2023 •
edited
Loading

Updates

  • Migrate Storybook builds for @carbon/charts-react from Webpack to Vite (turned off autodocs and codegen)
  • Bump node, lerna, storybook, vite, @vitejs/plugin-react, svelte, sveltekit, typescript, eslint, @typescript/*, @rushstack/eslint-patch, prettier, @carbon icons, @carbon/styles, @carbon/themes, jsdom, vite-plugin-dts, @vitejs/plugin-react, vitest and a few @types.
  • Add nx cache to gitignore
  • Drop @babel*, @storybook/testing-library, @storybook/react (only needs @storybook/react-vite), css-loader, style-loader, webpack (latter three are still there as sub-dependencies for Angular and @storybook/angular but don't need to be explicitly loaded)
  • Add @storybook/test (replaces @storybook/testing-library)
  • Add @nrwl/devkit to prevent yarn install errors (peer of lerna)
  • Hoisted eslint and related config and plugins, vue (to address storybook issue)
  • Updated README.md files to recommend loading styles from dist/styles.css (in case webpack is used since it doesn't read package.json exports)
  • Removed unused imports from react storybooks
  • Fixed issue with demo.scss where $css--font-face variable was being ignored causing console errors about not being able to load Plex from node_modules (it's loaded in Storybooks in the <head>)
  • Applied previous fix for Svelte Storybook to MDX in core which is copied to the Svelte package during builds (was overwriting)
  • Fixed README.md files to advise users to import CSS from /dist/styles.css in case they are using Webpack.
  • Applied Vite mergeConfig to Storybook viteFinal functions as this is the recommended way to modify Vite configuration for Storybook and provides better typing.
  • Disabled Storybook telemetry

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners November 29, 2023 00:40
@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit b44cad8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65807349795332000825b392
😎 Deploy Preview https://deploy-preview-1691--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit b44cad8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/6580734968dd660008b6432d
😎 Deploy Preview https://deploy-preview-1691--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit b44cad8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/658073497281150008845a11
😎 Deploy Preview https://deploy-preview-1691--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant nstuyvesant changed the title Bump for dependencies DO NOT MERGE - Bump for dependencies (working on Storybook issues unsurprisingly) Nov 29, 2023
@nstuyvesant nstuyvesant changed the title DO NOT MERGE - Bump for dependencies (working on Storybook issues unsurprisingly) DO NOT MERGE - Bump for dependencies (working on Storybook issues with charts-react unsurprisingly) Nov 29, 2023
@nstuyvesant
fix(storybook): remove type: module in package.json
35b7677
@nstuyvesant
chore(app): bump @babel, storybook, jsdom, vite, vite-plugin-dts
cad8372
@nstuyvesant
chore(app): bump storybook
a06297a
@nstuyvesant
Merge branch 'master' into bump
3297426
@nstuyvesant
chore(app): bump node
e7d2395
@nstuyvesant
chore(app): bump storybook, @carbon/icons, eslint, eslint-config-pret…
738cdc8 
…tier, @carbon/styles. @carbon/themes, @types/react, publint, @vitejs/plugin-vue
@nstuyvesant
chore(app): bump @typescript*, vite, @vitejs/plugin-react, @types/rea…
3f0f72d 
…ct, vitest
@nstuyvesant
Merge branch 'master' into bump
1322e09
@nstuyvesant
chore(app): remove @babel*, @rushstack/eslint-patch, @storybook/testi…
28b4780 
…ng, @storybook/react (using react-vite), bump sveltekit, storybook, @carbon/icons, @typescript*, @carbon/styles, eslint, vite, typescript, vitest, prettier-eslint, hoist eslint (and plugins)
@nstuyvesant
docs(readme): importing from dist/styles.css instead of package root …
5194912 
…in case webpack is used
@nstuyvesant
refactor(react stories): get rid of unused imports
81af58c
@nstuyvesant
refactor(react storybook): switch react storybook from webpack to vite
3b4af6d
@nstuyvesant
chore(app): remove @storybook/addon-onboarding
32702d5
@nstuyvesant
fix(demo): don't assume plex is locally installed
92bbb79
@nstuyvesant
fix(react storybook): switch docgen type
4c2bb03
@nstuyvesant
fix(react storybook): issue with can't find variable: dc
d4b43ed
@nstuyvesant
fix(react storybook): docgen issue
cfe5261
@nstuyvesant
fix(react storybook): try eliminating treeshaking
071efb1
@nstuyvesant
fix(react storybook): remove extra add-ins
d896765
@nstuyvesant
fix(react storybook): test
18507d8
@nstuyvesant
fix(react storybook): try patching versions
edb5710
@nstuyvesant
chore(app): bump sveltekit, add debug for react storybook
d28f159
@nstuyvesant nstuyvesant changed the title DO NOT MERGE - Bump for dependencies (working on Storybook issues with charts-react unsurprisingly) @carbon/charts-react Storybook builds to use vite, minor Storybook CSS issue causing warnings in console, bumped dependencies, docs cleanup Dec 18, 2023
@nstuyvesant nstuyvesant changed the title @carbon/charts-react Storybook builds to use vite, minor Storybook CSS issue causing warnings in console, bumped dependencies, docs cleanup @carbon/charts-react Storybook builds use vite instead of webpack, fixed minor Storybook CSS issue causing warnings in console, bumped dependencies, docs cleanup Dec 18, 2023
@theiliad theiliad merged commit 766dcac into carbon-design-system:master Dec 18, 2023
4 checks passed
@nstuyvesant nstuyvesant deleted the bump branch December 18, 2023 17:22
@dabrad26 dabrad26 mentioned this pull request Jan 2, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

Assignees
No one assigned
Labels
affects: build-process affects: dependencies type: docs 📖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstuyvesant @theiliad