Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): only externalize jsx-runtime #1937

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

theiliad
Copy link
Member

@theiliad theiliad commented Jan 7, 2025

No description provided.

@theiliad theiliad requested a review from a team as a code owner January 7, 2025 19:58
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit d9c978d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/677d874e1a319e000844345f
😎 Deploy Preview https://deploy-preview-1937--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit d9c978d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/677d874e974bd9000824e142
😎 Deploy Preview https://deploy-preview-1937--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theiliad theiliad merged commit 5edea11 into main Jan 7, 2025
3 of 5 checks passed
@theiliad theiliad deleted the theiliad-externalize-jsx-runtime branch January 7, 2025 19:58
Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for carbon-charts-docs ready!

Name Link
🔨 Latest commit d9c978d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-docs/deploys/677d874ed1ced90008175096
😎 Deploy Preview https://deploy-preview-1937--carbon-charts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit d9c978d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/677d874e601fc600083f17b9
😎 Deploy Preview https://deploy-preview-1937--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dabrad26
Copy link
Member

dabrad26 commented Jan 8, 2025

I am seeing issues with latest carbon charts. Seems it is bundling React as well? I feel we should not bundle react or any of the peer dependencies?

    A React Element from an older version of React was rendered. This is not supported. It can happen if:
    - Multiple copies of the "react" package is used.
    - A library pre-bundled an old copy of "react" or "react/jsx-runtime".
    - A compiler tries to "inline" JSX instead of using the runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants