Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchor rel tag missing in clickable tile for security #2996

Closed
grishma-shah7 opened this issue Sep 18, 2024 · 1 comment · Fixed by #2997
Closed

anchor rel tag missing in clickable tile for security #2996

grishma-shah7 opened this issue Sep 18, 2024 · 1 comment · Fixed by #2997

Comments

@grishma-shah7
Copy link
Contributor

grishma-shah7 commented Sep 18, 2024

Need rel=noopener noreferrer attributes in clickable tile as it has target attribute

⚠️ Note: PR for fix already up, needs review

Detailed description

Describe in detail the issue you're having.
cds-clickable-tile has href target properties, but it is missing the Security HTML anchor rel when target is set

Is this a feature request (new component, new icon), a bug, or a general issue?
general issue

Is this issue related to a specific component?
Clickable Tile

What did you expect to happen? What happened instead? What would you like to see changed?
rel attribute is added

What browser are you working in?
Chrome, Firefox, safari

What version of the Carbon Design System are you using?
latest

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Copy link

🎉 This issue has been resolved in version 5.40.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant