-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add rel attribute to clickable tile anchor tag #2997
Merged
Akshat55
merged 4 commits into
carbon-design-system:master
from
grishma-shah7:issue2996
Sep 30, 2024
Merged
fix: add rel attribute to clickable tile anchor tag #2997
Akshat55
merged 4 commits into
carbon-design-system:master
from
grishma-shah7:issue2996
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
yinglejia
suggested changes
Sep 19, 2024
yinglejia
approved these changes
Sep 23, 2024
Akshat55
approved these changes
Sep 30, 2024
Akshat55
changed the title
fix: adds rel attribute to clickable tile anchor tag
fix: add rel attribute to clickable tile anchor tag
Sep 30, 2024
🎉 This PR is included in version 5.40.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2996
This PR adds the rel attribute to the anchor tag in the clickable tile for security
Similar security also observed in the anchor tag for overflow menu options component