Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rel attribute to clickable tile anchor tag #2997

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

grishma-shah7
Copy link
Contributor

closes #2996

This PR adds the rel attribute to the anchor tag in the clickable tile for security

Similar security also observed in the anchor tag for overflow menu options component

@grishma-shah7 grishma-shah7 requested a review from a team as a code owner September 18, 2024 14:21
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 9cbe05d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/66fadaefa0cf510008f882e5
😎 Deploy Preview https://deploy-preview-2997--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 18, 2024

DCO Assistant Lite bot All contributors have signed the DCO.

@grishma-shah7
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

src/tiles/clickable-tile.component.ts Outdated Show resolved Hide resolved
src/tiles/clickable-tile.component.ts Outdated Show resolved Hide resolved
@Akshat55 Akshat55 changed the title fix: adds rel attribute to clickable tile anchor tag fix: add rel attribute to clickable tile anchor tag Sep 30, 2024
@Akshat55 Akshat55 merged commit 2848b6b into carbon-design-system:master Sep 30, 2024
14 checks passed
Copy link

🎉 This PR is included in version 5.40.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anchor rel tag missing in clickable tile for security
3 participants