Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mild updates required to the style page on Breadcrumbs #2821

Open
mbgower opened this issue Mar 28, 2022 · 0 comments
Open

Some mild updates required to the style page on Breadcrumbs #2821

mbgower opened this issue Mar 28, 2022 · 0 comments

Comments

@mbgower
Copy link
Contributor

mbgower commented Mar 28, 2022

On the Style page, some of the information may need attention.

Under Color, there is a series of images showing state appearance
image

  • The Focus state should have both a focus indicator and a blue underline
  • I don't think the Active image should exist. isn't the "Current page" the same as active? And I can't think of a situation where you'd have an underlined non-interactive element.

Under Truncated breadcrumbs, the page states:

Truncated breadcrumbs are not currently built into the breadcrumb component

It's unclear if this means that a page link (i.e., page name that is a breadcrumb link) is never truncated. There are no illustrations. This sentence is then followed by a comment on the overflow menu, which can either be interpreted as a further puzzling comment on the first sentence, or a related topic about where not all breadcrumbs are shown (truncating the number of links listed, as opposed to truncating a portion of a single link name). The guidance needs to be clarified.

Under the Structure section, there is an image of an expanded breadcrumb overflow menu, which lacks a focus indicator on the first item (Breadcrumb 2) in the expanded list. This is the same issue (but different page) identified in #2815
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

3 participants