Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add basic tests for slug prop on components #15273

Closed
1 task done
tw15egan opened this issue Nov 27, 2023 · 4 comments · Fixed by #15792
Closed
1 task done

[Feature Request]: Add basic tests for slug prop on components #15273

tw15egan opened this issue Nov 27, 2023 · 4 comments · Fixed by #15792
Assignees
Labels
area: AI Used to filter issues in the Carbon for AI project. role: dev 🤖 type: enhancement 💡

Comments

@tw15egan
Copy link
Member

The problem

We should ensure the slug is being rendered properly in the components we have implemented it in

The solution

We should have basic tests to check for the existence of the slug inside these components, as well as basic AVT and keyboard naviagtion tests.

Examples

No response

Application/PAL

No response

Business priority

None

Available extra resources

No response

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@tw15egan tw15egan added the area: AI Used to filter issues in the Carbon for AI project. label Nov 27, 2023
@tw15egan
Copy link
Member Author

@mattrosno Added this as a stub for now, but we should write some basic tests to ensure there are no regressions once most of the components have been updated to handle the Slug component.

@mattrosno
Copy link
Member

@tw15egan given the slug will remain experimental for the foreseeable future, is this something that we want to do in phase 1 (12/15/23)?

@mattrosno
Copy link
Member

@tw15egan @sstrubberg C4AI phase 2 milestone date is 2/23/24. If this won't get done by then, can we remove it from the phase 2 milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI Used to filter issues in the Carbon for AI project. role: dev 🤖 type: enhancement 💡
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants