Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accordion: Controlled Tab] Addressing 'Click to Expand All' and 'Click to Collapse All' Prop Concerns #15896

Open
1 task
Kritvi-bhatia17 opened this issue Mar 5, 2024 · 3 comments
Labels
component: accordion proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ type: enhancement 💡

Comments

@Kritvi-bhatia17
Copy link
Contributor

Kritvi-bhatia17 commented Mar 5, 2024

Problem

In the Controlled tab under Accordion, there are concerns regarding the "Click to expand all" and "Click to collapse all" props:

  1. Placing two primary CTAs/buttons next to each other is not recommended.
  2. This could potentially create confusion for users, as the CTAs seem like a part of the component/design rather than just props.

It's necessary to examine other components where similar props are utilized.

Ref: Issue #15757

Screenshot 2024-03-06 at 12 24 26 AM

Possible solution

  1. Consider creating a tab called 'Examples' under 'Accordion' to accommodate the 'Controlled' tab.
  2. Explore alternative placements or methods for presenting the CTAs.
    Example - Migrate to Carbon
    Screen Recording 2024-03-18 at 8 20 13 PM

Tasks

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@alina-jacob
Copy link
Member

Here's a reference link for an existing design (by w3) around "Expand/Collapse all" feature for Accordion.

Also sharing some simple draft explorations presented in Design-crit.
Controlled Accordion

@sstrubberg
Copy link
Member

Let's make a list of the ones that don't make sense.. i.e.- the controlled stories and make them available for devs only in the local developer environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ type: enhancement 💡
Projects
Status: Later 🧊
Development

No branches or pull requests

3 participants