From c5ce14f7c347d40b3a789e01b4edf27545df9bdb Mon Sep 17 00:00:00 2001 From: Thamjith Thaha Date: Wed, 23 Oct 2024 20:09:04 +0530 Subject: [PATCH 1/2] fix(Dropdown): made the titleText optional in propTypes --- packages/react/src/components/Dropdown/Dropdown.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/components/Dropdown/Dropdown.tsx b/packages/react/src/components/Dropdown/Dropdown.tsx index 7ff281908c70..2009b4b2972b 100644 --- a/packages/react/src/components/Dropdown/Dropdown.tsx +++ b/packages/react/src/components/Dropdown/Dropdown.tsx @@ -796,7 +796,7 @@ Dropdown.propTypes = { * Provide the title text that will be read by a screen reader when * visiting this control */ - titleText: PropTypes.node.isRequired, + titleText: PropTypes.node, /** * Callback function for translating ListBoxMenuIcon SVG title From 1f5c1e271307f94fd8580c2c6e415cf3ce90db4f Mon Sep 17 00:00:00 2001 From: Thamjith Thaha Date: Wed, 23 Oct 2024 20:13:12 +0530 Subject: [PATCH 2/2] docs(Contributors): updated the contributors list --- .all-contributorsrc | 9 +++++++++ README.md | 1 + 2 files changed, 10 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 076e56e06ff7..8425488a310d 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1670,6 +1670,15 @@ "contributions": [ "code" ] + }, + { + "login": "Thamjith", + "name": "Thamjith Thaha", + "avatar_url": "https://avatars.githubusercontent.com/u/24909620?v=4", + "profile": "https://github.com/Thamjith", + "contributions": [ + "code" + ] } ], "commitConvention": "none" diff --git a/README.md b/README.md index 8110558a92cb..8c4a7fd448b3 100644 --- a/README.md +++ b/README.md @@ -310,6 +310,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
Divya G

💻
Soumya Raju

💻
Ziyad Bin Sulfi

💻 +
Thamjith Thaha

💻
Mariat

💻