Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript error when extending multiple RestProps #137

Open
metonym opened this issue Oct 20, 2024 · 0 comments · May be fixed by #138
Open

TypeScript error when extending multiple RestProps #137

metonym opened this issue Oct 20, 2024 · 0 comments · May be fixed by #138
Assignees
@metonym
Labels
bug Something isn't working

Comments

@metonym
Copy link
Collaborator

metonym commented Oct 20, 2024

If Sveld infers that $$restProps are passed to multiple elements, it uses an intersection & type.

However, this produces a TypeScript error in the interface.

type RestProps = SvelteHTMLElements["ul"] & SvelteHTMLElements["ol"];

export interface RecursiveListProps extends RestProps {

A breaking change and fix would be to use a type alias instead of interface for the generated props.

E.g.,

export type RecursiveListProps = RestProps & {
@metonym metonym added the bug Something isn't working label Oct 20, 2024
@metonym metonym self-assigned this Oct 20, 2024
@metonym metonym linked a pull request Oct 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metonym metonym

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(writer)!: use type alias instead of interface for RestProps carbon-design-system/sveld
1 participant
@metonym