Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pre and post<OperationName>Operation be _post<OperationName>Operation? #306

Open
tfogo opened this issue Dec 8, 2017 · 2 comments
Assignees

Comments

@tfogo
Copy link
Contributor

tfogo commented Dec 8, 2017

Adding _ would emphasize that in general it shouldn't be overridden unless you know what you're doing.

@chrisckchang
Copy link
Contributor

just a reminder: relevant doc section that would need changing https://docs.carbon.io/en/master/packages/carbond/docs/guide/collections/collection-operation-hooks.html

@gregbanks
Copy link
Contributor

adding a leading underscore would also have the side effect of filtering it from class refs. i wish there was a better distinction between protected/private members...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants