CIP-0142? | Web-Wallet Bridge - Network Determination #972
Conversation
updated the CIP number in readme Co-authored-by: Robert Phair <[email protected]>
added description to the motivation section Co-authored-by: Robert Phair <[email protected]>
added description to the rationale section Co-authored-by: Robert Phair <[email protected]>
|
@nathanbogale - before we continue with this one - why did you pull the plug on #960? We need to follow a proper review process in every case: and the other PR was already discussed at meetings, obtained online discussion and review, etc. This community interaction makes these documents quite different than just the posted material. @Ryun1 @Crypto2099 @perturbing I would recommend that this PR be closed and #960 be reopened to preserve that continuity: unless some practical argument is made against that here. Of course we will need the author's cooperation to do that and hope consensus is achieved about that before any action is taken in this PR. |
I second this! |
|
OK @nathanbogale - with @Ryun1's seconding the motion, I am bouncing this & reopening the original PR. If there is some critical flaw of the original PR please post exactly what that is & we will revise accordingly. |
|
I see @nathanbogale that you have destroyed PR #960 by deleting its branch. I sincerely hope you never do anything like that again: especially after editors have devoted their time to reviewing at a meeting, assigning a PR number, and conducted active and committed reviews. Since this has effectively become an unreviewed PR I'll remove the CIP number assignment and tag it for |
rphair
added
State: Triage
rphair
changed the title
There was a problem hiding this comment.
Due to #960 (comment) we will have to leave both PRs in the Discussions: list:
@nathanbogale a recommendation in CIP-0001 is to use the purpose of the CIP rather than a void number: e.g. |
|
@nathanbogale regarding #972 (comment) I meant that assigning a generic name in place of a CIP number is simply a good way of providing a convenient branch name that doesn't have to change. I didn't realise that you were going to be backing the number You can reinstate the number @Ryun1 @Crypto2099 @perturbing I've looked through the new branch & it's a practically identical copy of the deleted one, so effectively it's been |
rphair
changed the title
rphair
added
State: Confirmed
…cussion link" This reverts commit daae1b8. Added cardano-foundation#971 to the discussion
This PR introduces a new CIP that extends CIP-0030 to allow dApps to determine the specific network magic number of the connected Cardano network. While the existing getNetworkId() function only distinguishes between mainnet (1) and testnet (0), this extension enables dApps to identify specific test networks (preview, preprod, etc.) through their magic numbers.
Key features:
Adds getNetworkMagic() function under cip-0142 namespace
Maintains full backwards compatibility with CIP-0030
Reuses existing error handling patterns
Simple, focused solution for network identification
This extension will help dApps better configure themselves based on the specific test network they're connected to, improving the development and testing experience in the Cardano ecosystem.
Resolves: #489
(rendered proposal)