plutus: 1.30 -> 1.34.1 #1544
Open
plutus: 1.30 -> 1.34.1 #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch1bo
force-pushed
the
master
branch
2 times, most recently
from
53b33e9
to
8d8d3a3
Compare
|
Currently waiting for IntersectMBO/ouroboros-consensus#1207 to progress on 1.32 |
locallycompact
force-pushed
the
lc/plutus-1.31
branch
2 times, most recently
from
4b22075
to
73c1aa6
Compare
locallycompact
force-pushed
the
lc/plutus-1.31
branch
2 times, most recently
from
e1f2dc3
to
31f0f44
Compare
ch1bo
reviewed
Sep 9, 2024
hydra-plutus/scripts/mDeposit.plutus
Outdated
There was a problem hiding this comment.
I think we would want to keep this file.
There was a problem hiding this comment.
It doesn't seem to be in the tests for this branch. I think the script got merged in the refactor but not the logic.
ch1bo
reviewed
Sep 9, 2024
| @@ -41,3 +41,6 @@ benchmarks: True | |||
|
|
|||
| -- Always show detailed output for tests | |||
| test-show-details: direct | |||
|
|
|||
| allow-newer: base | |||
| allow-newer: plutus-ledger-api | |||
There was a problem hiding this comment.
Which packages do need these constraints? There is a nice syntax here to provide more context. I think it goes like: allow-newer: somepkg:base to say that somepkg needs to have its upper bounds removed for base
There was a problem hiding this comment.
We don't this is is noise.
There was a problem hiding this comment.
This is noise from ghc 9.10. Not relevant to this PR.
locallycompact
force-pushed
the
lc/plutus-1.31
branch
4 times, most recently
from
61aae8f
to
662e3b9
Compare
locallycompact
force-pushed
the
lc/plutus-1.31
branch
from
662e3b9
to
aefb8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.